Rename Rust types to match spec; remove UNION_NAME_OVERRIDES + ENUMERATION_NAME_OVERRIDES#96
Merged
Merged
Conversation
This was referenced Jun 10, 2026
Member
Author
This was referenced Jun 10, 2026
Member
Author
Merge activity
|
lorisleiva
changed the base branch from
loris/spec-gen-value-box-rule
to
graphite-base/96
…ATION_NAME_OVERRIDES This PR aligns nine hand-written Rust types with the spec's pascalCase defaults so the generator no longer needs name-override tables. Renamed: `ConditionNode` \u2192 `ConditionalValueCondition`; `EnumVariantData` \u2192 `EnumValuePayload`; `InstructionByteDeltaNodeValue` \u2192 `InstructionByteDeltaValue`; `InstructionRemainingAccountsNodeValue` \u2192 `InstructionRemainingAccountsValue`; `PdaSeedValueValueNode` \u2192 `PdaSeedValueValue`; `PdaValue` \u2192 `PdaValuePda`; `PdaProgramIdValueNode` \u2192 `PdaValueProgramId`; `Endian` \u2192 `Endianness`; `InstructionOptionalAccountStrategy` \u2192 `OptionalAccountStrategy`. With every Rust name now matching `pascalCase(specName)`, `UNION_NAME_OVERRIDES` and `ENUMERATION_NAME_OVERRIDES` are deleted from `spec-generators/src/defaults.ts` and all of their consumers (`typeExpr.ts`, `unionPage.ts`, `index.ts`) collapse to plain `pascalCase(name)`. The inline-union file-name path also reverts to following the spec union name directly (e.g. `enumValuePayload` \u2192 `enum_value_payload.rs` matching its now-spec-default type `EnumValuePayload`). Cuts the generator's override surface from seven maps to five.
lorisleiva
force-pushed
the
loris/spec-gen-rename-rust-types
branch
from
9958eea to
0a24115
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns nine hand-written Rust types with the spec's pascalCase defaults so the generator no longer needs name-override tables. Renamed:
ConditionNode\u2192ConditionalValueCondition;EnumVariantData\u2192EnumValuePayload;InstructionByteDeltaNodeValue\u2192InstructionByteDeltaValue;InstructionRemainingAccountsNodeValue\u2192InstructionRemainingAccountsValue;PdaSeedValueValueNode\u2192PdaSeedValueValue;PdaValue\u2192PdaValuePda;PdaProgramIdValueNode\u2192PdaValueProgramId;Endian\u2192Endianness;InstructionOptionalAccountStrategy\u2192OptionalAccountStrategy. With every Rust name now matchingpascalCase(specName),UNION_NAME_OVERRIDESandENUMERATION_NAME_OVERRIDESare deleted fromspec-generators/src/defaults.tsand all of their consumers (typeExpr.ts,unionPage.ts,index.ts) collapse to plainpascalCase(name). The inline-union file-name path also reverts to following the spec union name directly (e.g.enumValuePayload\u2192enum_value_payload.rsmatching its now-spec-default typeEnumValuePayload). Cuts the generator's override surface from seven maps to five.