Skip to content

Fix memory leak. #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
star-e merged 3 commits into from
May 12, 2026
+28 −24
Merged

Fix memory leak. #541

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d27fe0
Fix memory leak.
bofeng-song May 7, 2026
5c8f628
Merge branch 'main' of github.com:cocos/cocos-cli into mem
bofeng-song May 8, 2026
3787f97
Merge branch 'main' of github.com:cocos/cocos-cli into mem
bofeng-song May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 28 additions & 24 deletions src/core/scene/scene-process/service/gizmo/node/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,26 @@ class TransformGizmo extends GizmoBase<Component> {
this._gizmo.show();
}

private _eventMap: { [key: string]: () => void } = {
toolNameChanged: () => {
const toolName = getService()?.Gizmo?.transformToolData?.toolName ?? 'position';
this.changeTool(toolName as TransformToolDataToolNameType);
},
};
private _eventMap: { [key: string]: () => void } = {};

private _initEventMap() {
if ('toolNameChanged' in this._eventMap) return;
this._eventMap.toolNameChanged = () => {
const tn = getService()?.Gizmo?.transformToolData?.toolName ?? 'position';
this.changeTool(tn as TransformToolDataToolNameType);
};
this._eventMap.viewModeChanged = () => {
repaintEngine();
};
this._eventMap.pivotChanged = () => {
(this._gizmo as any).updateControllerTransform?.();
repaintEngine();
};
this._eventMap.coordinateChanged = () => {
(this._gizmo as any).updateControllerTransform?.();
repaintEngine();
};
}

init() {
(this._gizmo as any).init?.();
Expand All @@ -106,34 +120,24 @@ class TransformGizmo extends GizmoBase<Component> {
super.onShow();
}

this._initEventMap();

const svc = getService();
const toolName = svc?.Gizmo?.transformToolData?.toolName ?? 'position';
this.changeTool(toolName as TransformToolDataToolNameType);

this._eventMap.toolNameChanged = () => {
const tn = getService()?.Gizmo?.transformToolData?.toolName ?? 'position';
this.changeTool(tn as TransformToolDataToolNameType);
};

this._eventMap.viewModeChanged = () => {
repaintEngine();
};
this._eventMap.pivotChanged = () => {
(this._gizmo as any).updateControllerTransform?.();
repaintEngine();
};
this._eventMap.coordinateChanged = () => {
(this._gizmo as any).updateControllerTransform?.();
repaintEngine();
};

const ttd = svc?.Gizmo?.transformToolData;
// 先移除旧监听，防止重复 onShow 导致监听器累积
ttd?.removeListener?.('tool-name-changed', this._eventMap.toolNameChanged);
ttd?.removeListener?.('view-mode-changed', this._eventMap.viewModeChanged);
ttd?.removeListener?.('pivot-changed', this._eventMap.pivotChanged);
ttd?.removeListener?.('coordinate-changed', this._eventMap.coordinateChanged);

ttd?.addListener?.('tool-name-changed', this._eventMap.toolNameChanged);
ttd?.addListener?.('view-mode-changed', this._eventMap.viewModeChanged);
ttd?.addListener?.('pivot-changed', this._eventMap.pivotChanged);
ttd?.addListener?.('coordinate-changed', this._eventMap.coordinateChanged);

// 直接调用 onShow
this._gizmo.onShow?.();
}

Expand Down
Loading