Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Dec 19, 2025

The tests before where partly relying one a global context, which means
the cancelation from ginkgo wasn't really passed down. The leaf
functions can take a context.Context or SpecContext argument. The latter
is already imported, so lets go with that one.

The tests before where partly relying one a global context, which means
the cancelation from ginkgo wasn't really passed down. The leaf
functions can take a context.Context or SpecContext argument. The latter
is already imported, so lets go with that one.
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 49.01% (ø)

Coverage by file

Changed unit test files

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/aggregates_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/decomission_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/eviction_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_maintenance_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_certificate_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/node_eviction_label_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/onboarding_controller_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/suite_test.go
  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/traits_controller_test.go

@fwiesel fwiesel merged commit 94973f2 into main Dec 19, 2025
6 checks passed
@fwiesel fwiesel deleted the spec_context branch December 19, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants