Fix data.split in modern browsers#36
Open
TheSkorm wants to merge 1 commit into
Open
Conversation
Owner
|
This is a significant departure from the existing codebase :-/ it's a little too much for me to stomach here for a legacy project :-/ I will leave this PR open for others. If anyone else comes along and tests it then I would consider keeping it. |
psanogo
approved these changes
Oct 16, 2025
Owner
|
If others have material feedback I am happy to consider it. I just noticed the approve. But I wanted someone to make it clear what they were interested in/why. Also any changes would probably do well to go through https://github.com/cnlohr/esp82xx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems something has changed in modern browsers since this was built. There's no longer a synchronous way of accessing blob data so rather we need to load it into a filereader and add an event listener.