refactor: Replace deprecated iteritems() with items() for Python 3 compatibility#925
Open
shbhmexe wants to merge 1 commit intocncf:masterfrom
Open
refactor: Replace deprecated iteritems() with items() for Python 3 compatibility#925shbhmexe wants to merge 1 commit intocncf:masterfrom
shbhmexe wants to merge 1 commit intocncf:masterfrom
Conversation
…mpatibility Replace all instances of the deprecated dict.iteritems() method with dict.items() for Python 3 compatibility across core data processing files. Also update print statements to print() functions in affected code sections. Files modified: - src/csvdump.py: Replace iteritems() with items() in patch file type iteration - src/database.py: Replace iteritems() with items() in file data iteration - src/reports.py: Replace iteritems() with items() and update print statements in ReportByFileType function (4 occurrences) This change ensures the codebase is fully compatible with Python 3 while maintaining backward compatibility. The iteritems() method was removed in Python 3 and items() provides equivalent functionality in both Python 2.7+ and Python 3.x. Impact: No functional changes, only syntax updates for Python 3 compatibility. All existing functionality remains intact. Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Python 2 to Python 3 compatibility issues by replacing all remaining instances of the deprecated
dict.iteritems()method withdict.items()and updating related print statements to use Python 3'sprint()function.Changes Made
Fixed
iteritems()deprecation in 3 files:patch.filetypes.iteritems()withpatch.filetypes.items()patch.files.iteritems()withpatch.files.items()iteritems()withitems()in theReportByFileTypefunctionUpdated print statements in src/reports.py:
print()function calls (5 occurrences in lines 560, 562, 570, 572, 577)Rationale
The
iteritems()method was removed in Python 3. Usingitems()ensures:items()is available in Python 2.7+Testing
✅ Syntax validation passed for all modified files using
python -m py_compile✅ No functional changes - only syntax updates
Impact
Checklist: