Open
Conversation
2225c81 to
c0d732e
Compare
* what: if the return code of the rpm process is 2, check if the failure reason is that the package is already installed. * why: when reusing a container, the package might already be present. this occurs when a build runner job must be debugged. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
* what: add option --tls-verify to subcommands build and runner build. pass the tls-verify flag to skopeo when querying the registry. check if the return value from skopeo inspect equals "not found" (exit code 2). * why: if the image is pushed to a local container registry with a self-signed certificate, skopeo must not verify the certificate to avoid errors. current versions of skopeo (1.20.0) return exit code 2 if an image is not found. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
* what: pass the tls-verify flag to buildah when pushing to the registry. * why: if the image is pushed to a local container registry with a self-signed certificate, buildah must skip certificate verification to avoid errors Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
* what pass base_url (schema + authority) and gpg signing options to the build script. replace base_url in container.yaml with the local url or the s3 url. mount the folders containing the rpms using buildah when building locally. * why to build an image for testing purposes without deploying rpms to the production environment, it is necessary to mock the remote storage. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
* what: add a --dev flag, which can also be set via an environment variable, to allow http git urls. * why: during development and testing, the bootstrapped gitea server does not have a trusted certificate, making http necessary. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
* what: add an integration test structure to the root project. add a resources folder inside the test directory. add an integration test for the cbscore build. * why: integration tests should be kept as global as possible. the test ensures the build process works correctly for local builds. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>
c0d732e to
2c4535f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what:
bypass the s3 upload and use the local filesystem as a repository instead.
why:
to support test cases and local builds intended solely for testing purposes.