crt: add option to run local by UweSchwaeke · Pull Request #21 · clyso/cbs

UweSchwaeke · 2026-01-22T11:28:46Z

crt: introduce --local-run option

what:
introduce an option flag signaling the crt tool to run locally. "locally" means the tool will not access remote repositories. commands and subcommands that explicitly require remote access will simply ignore the flag.
why:
this enables the crt tool to operate without a connection to remote repositories or the internet. it allows users to perform preparatory tasks—such as starting a release adding, removing manifests or adding patches, using only local data. a network connection is now only strictly required when finalizing the release.

jecluis

@UweSchwaeke I've left some comments on the various commits.

Additionally, we need a proper description on this Pull Request, including what you are attempting to do. I'm a bit lost on what you are actually trying to achieve (maybe I forgot some of our initial chat on this).

So it would be nice to have the context on the PR description so we know what we are aiming for.

crt/src/crt/cmds/patchset.py

crt/src/crt/cmds/__init__.py

crt/src/crt/cmds/release.py

crt/src/crt/crtlib/manifest.py

crt/src/crt/crtlib/git_utils.py

crt/src/crt/cmds/release.py

UweSchwaeke · 2026-01-28T07:33:56Z

@UweSchwaeke I've left some comments on the various commits.

Additionally, we need a proper description on this Pull Request, including what you are attempting to do. I'm a bit lost on what you are actually trying to achieve (maybe I forgot some of our initial chat on this).

So it would be nice to have the context on the PR description so we know what we are aiming for.

I added a description.

jecluis · 2026-01-29T10:17:36Z

@UweSchwaeke on the commits' subjects, I'll need you to add a colon (:) between the component being changed and the subject.

UweSchwaeke · 2026-01-29T10:19:17Z

@UweSchwaeke on the commits' subjects, I'll need you to add a colon (:) between the component being changed and the subject.

just a moment i will fix it

jecluis · 2026-01-29T10:20:48Z

Also, please check the commit messages for typos. One example, the first commit shows:

don't check if release allready exists in remote

s/allready/already/

Additionally, ensure the commit messages are properly capitalized where it makes sense. While we don't want subject lines to be capitalized (unless required, e.g., to describe a CONSTANT_NAME), the commit message itself should come as easy-to-read text. I would also suggest adding a blank line between the commit's subject and the commit message body.

UweSchwaeke · 2026-01-29T14:08:59Z

Also, please check the commit messages for typos. One example, the first commit shows:

don't check if release allready exists in remote

s/allready/already/

Additionally, ensure the commit messages are properly capitalized where it makes sense. While we don't want subject lines to be capitalized (unless required, e.g., to describe a CONSTANT_NAME), the commit message itself should come as easy-to-read text. I would also suggest adding a blank line between the commit's subject and the commit message body.

i added a better description ( mostly reviewed with gemini)

jecluis

This looks sound, but I think we'll want to add some sort of functional tests to go along with it to make sure and validate.

crt/src/crt/cmds/__init__.py

jecluis · 2026-01-29T10:26:11Z

crt/src/crt/cmds/crt.py

+    is_flag=True,
+    default=False,
+    required=False,
+    help="run without accessing remotes",


Capitalize "Run", add a period (.) at the end, following what other options' help messages are doing.

Done thanks

crt/src/crt/cmds/manifest.py

crt/src/crt/cmds/release.py

jecluis · 2026-02-12T10:22:12Z

crt/src/crt/cmds/release.py

    summary_table.add_row("From Base Reference", f"{base_ref} from {base_ref_repo}")
    summary_table.add_row("Release base branch", release_base_branch)
    summary_table.add_row("Release base tag", release_base_tag)
+    summary_table.add_row("Is local", str(run_locally))


I'm not entirely sure if we should make this conditional. I wonder if it will be confusing for someone who's not using it as a local tool.

You mean, if someone let the script run through ssh or if its get called by a server or something?
Maybe i could make 2 Options:

Remove the line, so its quiet and the user doesn't get informed.

Rename "Is local" to something like "Ran without access to Remote repositories" and make it not part of the table instead a pinfo output.

What do you prefer? Or am i missing another option?

crt/src/crt/cmds/release.py

avoid accessing remotes if the flag is set and the subcommand doesn't require remote access. affected subcommands: * start: * skip adding remote URLs. * skip checking if the release already exists on the remote. * create a local release branch from base_ref (which must exist locally). * do not push the created branch or tag to the remote. * list: * skip adding remote urls. * skip fetching from remotes. other subcommands will ignore the flag. Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>

don't access remotes if the flag is set and the subcommand doesn't require remote access. affected subcommands: * patchset add: * don't add remote urls and don't fetch patch branch (assume branch exists locally) * validate: * don't add remote urls and don't fetch from remote other subcommands will ignore the flag Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>

don't access remotes if the flag is set and the subcommand doesn't require remote access. affected subcommands: * add: * don't add remote url and don't fetch Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>

don't access remotes if the flag is set and the subcommand doesn't require remote access. affected subcommands: * add: * don't add remote url and don't fetch * create branch from an existing local branch * publish: * don't add remote url and don't fetch * create branch from an existing local branch other subcommands will ignore the flag Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>

UweSchwaeke requested a review from jecluis January 22, 2026 12:55

jecluis requested changes Jan 23, 2026

View reviewed changes

UweSchwaeke force-pushed the wip-crt-local-run branch from d7afa8f to 6c0c518 Compare January 27, 2026 14:18

UweSchwaeke force-pushed the wip-crt-local-run branch from 6c0c518 to 6ec1cfe Compare January 29, 2026 13:55

UweSchwaeke marked this pull request as ready for review January 30, 2026 05:43

UweSchwaeke requested a review from jecluis February 3, 2026 19:36

UweSchwaeke force-pushed the wip-crt-local-run branch from 6ec1cfe to 00b6e12 Compare February 9, 2026 10:58

jecluis requested changes Feb 12, 2026

View reviewed changes

UweSchwaeke force-pushed the wip-crt-local-run branch from 00b6e12 to 5f6327f Compare February 12, 2026 13:28

UweSchwaeke force-pushed the wip-crt-local-run branch from 5f6327f to 91de79d Compare February 23, 2026 19:35

UweSchwaeke force-pushed the wip-crt-local-run branch 6 times, most recently from 7a200a6 to 5b1511b Compare March 11, 2026 11:29

UweSchwaeke force-pushed the wip-crt-local-run branch 4 times, most recently from ef460ae to 44ebc4d Compare March 11, 2026 12:50

UweSchwaeke force-pushed the wip-crt-local-run branch 2 times, most recently from 1e2f124 to f95accd Compare March 11, 2026 13:10

crt/cmds/patch: add --local-run option

0e71f05

don't access remotes if the flag is set and the subcommand doesn't require remote access. affected subcommands: * add: * don't add remote url and don't fetch Signed-off-by: Uwe Schwaeke <uwe.schwaeke@clyso.com>

UweSchwaeke force-pushed the wip-crt-local-run branch from f95accd to d64c217 Compare March 11, 2026 13:28

jecluis approved these changes Mar 12, 2026

View reviewed changes

jecluis merged commit a3d13d7 into clyso:main Mar 12, 2026

Conversation

UweSchwaeke commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jecluis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UweSchwaeke commented Jan 28, 2026

Uh oh!

jecluis commented Jan 29, 2026

Uh oh!

UweSchwaeke commented Jan 29, 2026

Uh oh!

jecluis commented Jan 29, 2026

Uh oh!

UweSchwaeke commented Jan 29, 2026

Uh oh!

jecluis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jecluis Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

UweSchwaeke Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jecluis Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

UweSchwaeke Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

UweSchwaeke commented Jan 22, 2026 •

edited

Loading

UweSchwaeke Feb 12, 2026 •

edited

Loading