fix(web): escape apostrophe in VIBE_TAGS — unblocks Vercel build#4
Draft
cloudygetty-ai wants to merge 2 commits into
Draft
fix(web): escape apostrophe in VIBE_TAGS — unblocks Vercel build#4cloudygetty-ai wants to merge 2 commits into
cloudygetty-ai wants to merge 2 commits into
Conversation
esbuild treats the unescaped apostrophe inside a single-quoted string as a syntax error (Expected "]" but found "s"). This has regressed twice — switching to double quotes is the permanent fix.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnboardingScreen.tsx:33—'Let's link'→\"Let's link\"(double-quoted)Root cause
esbuild parses single-quoted string literals strictly. An unescaped
'inside'...'terminates the string, leavings linkas unparsed tokens →Expected \"]\" but found \"s\".This bug has been introduced and fixed multiple times in this repo (the commit history shows fixes to
ProfileScreen,OnboardingScreen, andAIAssistantScreen). The permanent fix is to use double quotes for any string literal containing an apostrophe.Impact
The latest production deployment (
dpl_HLNitH6sGGPfwrBjwHqKXq7r2CaN) is in ERROR. Merging this PR will restore a green build.Test plan
VIBE_TAGSarray renders all 12 tags in the Vibe step of onboardinghttps://claude.ai/code/session_01421rRP38Tdx2tcr2cBPG3z
Generated by Claude Code