feat(volo): add feature vendored for native-tls#301
Merged
yukiiiteru merged 2 commits intocloudwego:mainfrom Jan 6, 2024
Merged
feat(volo): add feature vendored for native-tls#301yukiiiteru merged 2 commits intocloudwego:mainfrom
vendored for native-tls#301yukiiiteru merged 2 commits intocloudwego:mainfrom
Conversation
Member
|
Maybe the title could be clearer, and details can be put in commit messages, e.g.,
|
Add feature `vendored` that enables `tokio-native-tls/vendored`, and use it in CI to avoid installing additional packages.
ii64
force-pushed
the
fix/ci-native-tls-vendored
branch
from
9d0143c to
2876dfc
Compare
ii64
changed the title
vendored flag for volo native-tls, CI checkvendored for native-tls
yukiiiteru
approved these changes
Jan 5, 2024
PureWhiteWu
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Optional
vendoredfeature flag, follow up for #296 (comment)Users can choose wheter statically link native-tls library or using library that's provided by system package.
Solution
Add
vendoredfeature that enablestokio-native-tls/vendored, usevendoredflag in CI.