Fix Data Source Tag Filtering#143
Open
alakae wants to merge 6 commits into
Open
Conversation
The old filter loop used `m[key] != attr` for all attribute types. For TypeMap (tags), comparing two interface{} values whose dynamic type is map[string]interface{} panics in Go: maps are not comparable.
In practice this panic was masked: gather functions did not include "tags" in ResourceDataRaw, so m["tags"] was always nil. Comparing nil != someMap is safe and evaluates to true (no match), so the real provider silently returned "Found zero" rather than crashing.
This commit fixes both: it wires up TagsToState in every gather function so tags are actually returned, and replaces the generic != comparison with reflect.DeepEqual for scalars and subset-walk logic for TypeMap fields.
Makes it more clear what input and output of the funcs actually are.
Gather functions return []string directly from the SDK struct, but
d.GetOk on a schema.TypeList always returns []interface{}. The previous
reflect.DeepEqual call compared incompatible dynamic types and always
returned false, causing any TypeList filter to silently match nothing.
Add a TypeList/TypeSet branch that converts []string to []interface{}
via toInterfaceSlice before comparing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136