fix: plugin-barman-cloud port for readiness probe #776
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Larwig <jan@larwig.com>
tuunit
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
size:XS
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the readiness probe configuration for high-availability setups. The readiness probe was checking port 9090 (the application port), which is only available on the leader pod. In HA deployments with multiple replicas, non-leader pods would fail readiness checks since they only expose the health/metrics port 8081.
Key Changes:
- Updated readiness probe to use port 8081 instead of 9090 for proper HA support
- Bumped chart version from 0.4.0 to 0.4.1 (patch version for bug fix)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/plugin-barman-cloud/templates/deployment.yaml | Fixed readiness probe to check port 8081 (health/metrics) instead of 9090 (application port) |
| charts/plugin-barman-cloud/Chart.yaml | Incremented patch version to 0.4.1 to reflect the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment the port
9090is used for the readiness probe which is the application port which only get opened / used by the leader. For an HA setup with multiple pods this fails because none leaders only open the health/metrics port8081.Fixes #710