Make externalClusters conditional to prevent null value in standalone mode #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
spec.externalClusters: Invalid value: "null"error that occurs when deploying in standalone mode with backups disabled and using strict YAML validation (server-side apply).This fix aligns with upstream CloudNativePG charts PR #760 to minimize future rebase conflicts.
Root Cause
When
mode: standaloneandbackups.enabled: false, the generated YAML ends with:externalClusters:with no content. Strict YAML parsers interpret this as
externalClusters: nullinstead of an empty array, causing CNPG operator validation to fail.Changes Made
1. Fixed
_external_clusters.tplexternalClusters:field inside conditional logic2. Updated CI Validation
--server-side --validate=strictflags tokubectl applyin deploy-cluster actionTesting
Related