Skip to content

Call helper function for killUaa task#3934

Open
duanemay wants to merge 1 commit into
developfrom
exec_kill
Open

Call helper function for killUaa task#3934
duanemay wants to merge 1 commit into
developfrom
exec_kill

Conversation

@duanemay
Copy link
Copy Markdown
Member

@duanemay duanemay commented Jun 5, 2026

Simplify the killUaa call in integrationTests

To resolve feedback from #3684

Calling an Exec task by iterating and executing its internal actions bypasses Gradle’s normal task execution semantics and is brittle if the task’s actions change. Prefer invoking the Exec task’s exec() directly (or using project.exec) here.

Copilot AI review requested due to automatic review settings June 5, 2026 15:59
@duanemay duanemay changed the title Cal helper function for killUaa task Call helper function for killUaa task Jun 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the integrationTest task in the uaa module to stop UAA via a local helper function rather than manually invoking the root project’s killUaa task actions, aiming to simplify/process-isolate the shutdown behavior.

Changes:

  • Adds an injected ExecOperations holder and a killUaa() helper inside integrationTest.
  • Replaces repeated rootProject.tasks.named("killUaa").get().actions... calls with killUaa() calls.
  • Adds required imports to support Gradle service injection in the build script.

Comment thread uaa/build.gradle.kts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants