Conversation
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the codebase from Java 21 to Java 25, implementing several modern Java features:
- Replaces unused exception variables with underscore
_(JEP 443 - Unnamed Patterns and Variables) - Migrates from
System.out.println()toIO.println()utility class - Converts traditional switch statements to switch expressions
- Replaces
.get(0)with.getFirst()for better semantics - Updates Java version configuration across build and CI/CD files
Reviewed changes
Copilot reviewed 249 out of 250 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| build.gradle | Updates Java source and target compatibility from 21 to 25 |
| .github/workflows/*.yml | Updates CI/CD pipelines to use Java 25 |
| Test files (multiple) | Replaces unused exception variables with _, migrates to IO.println() |
| Main source files (multiple) | Same modernization patterns as test files |
| Switch statement files | Converts to switch expressions in SecurityFilterChainPostProcessor, SimpleSearchQueryConverter, StringUtilities |
| Collection access files | Replaces .get(0) with .getFirst() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
42
| void main() { | ||
| LdapSecurityConstants test = PasswordUtil.findAlgorithm("{sha}YaE1CJ6sVhov987e77A5db7QAPg=".getBytes()); | ||
| System.out.println(test); | ||
| IO.println(test); | ||
| } |
There was a problem hiding this comment.
The main method signature has been changed from public static void main(String[] args) to void main(). This breaks the standard Java main method contract and will prevent this class from being executed as an entry point. The signature should remain public static void main(String[] args) or follow Java 21+'s new main method conventions with void main(String[] args) if removing the args parameter is intentional.
strehle
reviewed
Jan 9, 2026
adrianhoelzl-sap
previously approved these changes
Jan 12, 2026
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
Member
Author
|
Waiting on:
|
Rewrite Rules applied - Replace unused variables with underscore - Migrate to IO utility class - Use switch expression
Rewrite Rules applied
Replace assertThatExceptionOfType with assertThatThrownBy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to update docker files, and uaa-release before merging this