Add nginx__1.13.6_dynamic_tls_records.patch#89
Open
alubbe wants to merge 1 commit intocloudflare:masterfrom
Open
Add nginx__1.13.6_dynamic_tls_records.patch#89alubbe wants to merge 1 commit intocloudflare:masterfrom
alubbe wants to merge 1 commit intocloudflare:masterfrom
Conversation
Author
|
Is there any interest in updating the patch to the new nginx versions? Or any feedback to my PR? |
|
But the old patch(1.11.5) is ok for me in nginx-1.13.8, there isn't any error |
|
Also, old patch hunked successful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old patch doesn't apply cleanly because of some refactoring in ngx_event_openssl.h. The new patch fixed that.