Skip to content

Fix status of skipped cucumber steps #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romovs merged 2 commits into from
Jun 11, 2026
Merged

Fix status of skipped cucumber steps #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ba29f2
[cucumber] Fix skipped steps not being marked as skipped
romovs Jun 11, 2026
20ef14b
[cucumber] 3.2.2
romovs Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cucumber/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cloudbeat/cucumber",
"version": "3.2.1",
"version": "3.2.2",
"description": "CloudBeat Test Reporting Kit for Cucumber.js",
"keywords": [
"cloudbeat",
Expand Down
26 changes: 17 additions & 9 deletions packages/cucumber/src/CbCucumberReporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,18 +416,26 @@ class CbCucumberReporter extends Formatter {
const attachments = this.attachmentsByTestStepIdMap.get(testStepId);
cbStepResult.endTime = (new Date()).getTime();
cbStepResult.duration = cbStepResult.endTime - cbStepResult.startTime!;
cbStepResult.status = ResultStatusEnum.PASSED;
// Add additional steps if provided in the attachments (like in case of Playwright integration)
addPlaywrightStepsAndScreenshotFromAttachments(cbStepResult, attachments);
// Determine step status
if (testStepResult && testStepResult.status === 'FAILED') {
cbStepResult.status = ResultStatusEnum.FAILED;
if (testStepResult.exception) {
cbStepResult.failure = getFailureFromException(testStepResult.exception);
}
else if (testStepResult.message) {
cbStepResult.failure = getFailureFromMessage(testStepResult.message);
}
switch (testStepResult?.status) {
case 'PASSED':
cbStepResult.status = ResultStatusEnum.PASSED;
break;
case 'SKIPPED':
cbStepResult.status = ResultStatusEnum.SKIPPED;
break;
default:
// FAILED, PENDING, UNDEFINED, AMBIGUOUS, UNKNOWN
cbStepResult.status = ResultStatusEnum.FAILED;
if (testStepResult?.exception) {
cbStepResult.failure = getFailureFromException(testStepResult.exception);
}
else if (testStepResult?.message) {
cbStepResult.failure = getFailureFromMessage(testStepResult.message);
}
break;
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/cucumber/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export interface TestStepFinished {
testCaseStartedId: string;
testStepId: string;
testStepResult: {
status: 'PASSED' | 'FAILED' | 'SKIPPED' | 'PENDING' | 'UNDEFINED';
status: 'UNKNOWN' | 'PASSED' | 'FAILED' | 'SKIPPED' | 'PENDING' | 'UNDEFINED' | 'AMBIGUOUS';
message: string;
exception: {
type: string;
Expand Down
Loading