Skip to content

Fix extra specs nil pointer deref #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabriel-samfira merged 1 commit into from
Jun 16, 2026
+7 −1
Merged

Fix extra specs nil pointer deref #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runner/pool/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ func (r *basePoolManager) persistJobToDB(ctx context.Context, jobParams params.J
"is_new_job", isNewJob,
"job_action", jobParams.Action,
)
return fmt.Errorf("job %d should not be recorded", jobParams.WorkflowJobID)
return fmt.Errorf("job %d should not be recorded: %w", jobParams.WorkflowJobID, runnerErrors.ErrUnprocessable)
}

slog.DebugContext(
Expand Down
6 changes: 6 additions & 0 deletions util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ func MaybeAddWrapperToExtraSpecs(ctx context.Context, param commonParams.Bootstr
return param
}
}
if data == nil {
// Unmarshal returned nil. An explicit `null` was probably passed.
// Any other valid json would either fail to unmarshal or unmarshal
// into an actual map we can use.
return param
}

if _, ok := data["runner_install_template"]; ok {
// User has already set a runner install template override. Do not touch.
Expand Down