Add proxy support for GARM#786
Merged
Merged
Conversation
This change adds the ability to set proxy config for the GARM daemon. The same settings will also apply to external providers when they are invoked. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
61b4c52 to
6d5bfe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the ability to set proxy config for the GARM daemon. The same settings will also apply to external providers when they are invoked.
Note: This does not affect runner install templates or runner proxy settings. That will be a separate PR, as it requires those settings to be exposed on a per pool/scaleset basis, considering pools and scale sets may spin up runners in different restricted environments.