Skip to content

feat(shared): add admin role fine grained permissions#1896

Merged
shikanime merged 1 commit intomainfrom
pr1896
Feb 26, 2026
Merged

feat(shared): add admin role fine grained permissions#1896
shikanime merged 1 commit intomainfrom
pr1896

Conversation

@shikanime
Copy link
Contributor

@shikanime shikanime commented Feb 4, 2026

This changes the behaviour of admin access from a single toggle to fine-tuned permissions.
The permissions hierarchy basically works as follows: Manage > ManageXXX > List.
There are a few exceptions, such as the project hierarchy, in which the Manage permission from admin roles gives access to certain resources inside a project, while ManageProjects only manages the resource itself.
This means that Manage acts as a sort of equivalent to sudo; it's an intermediary design choice, but it needs revising.

Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr
Change-Id: I07287d8d2c8fd287a9fbaefc9019f81a6a6a6964

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

🤖 Hey !

A preview of the application is available at : https://console-pr-1896.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

@shikanime shikanime force-pushed the pr1896 branch 3 times, most recently from 9158d91 to 8035ddb Compare February 16, 2026 16:21
@shikanime shikanime marked this pull request as ready for review February 16, 2026 16:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

🤖 Hey !

The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions github-actions bot added the built label Feb 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the pr1896 branch 9 times, most recently from d6319cc to 52cf7cf Compare February 18, 2026 10:15
@shikanime shikanime force-pushed the pr1896 branch 6 times, most recently from 2d50a46 to 8afec63 Compare February 18, 2026 15:06
@shikanime shikanime added this to the Gestion fins des droits milestone Feb 20, 2026
@shikanime shikanime added preview Deploy preview app with Argo-cd and removed preview Deploy preview app with Argo-cd labels Feb 20, 2026
@shikanime shikanime force-pushed the pr1896 branch 3 times, most recently from f802ff9 to c565fda Compare February 20, 2026 14:39
@shikanime
Copy link
Contributor Author

Before, the use can create projects
image

After, the user can't create any more projects but the behaviour of project mangement itself stay the same
image

@shikanime
Copy link
Contributor Author

According to the ADR19, the usage of custom role can re-establish the "legacy" behaviour

image

Such as

image

@shikanime
Copy link
Contributor Author

tl;dr the user can't create any more projects, sadge for him but good for us

image

StephaneTrebel
StephaneTrebel previously approved these changes Feb 23, 2026
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM 🚀

StephaneTrebel
StephaneTrebel previously approved these changes Feb 23, 2026
StephaneTrebel
StephaneTrebel previously approved these changes Feb 24, 2026
@shikanime
Copy link
Contributor Author

@StephaneTrebel Enfin, tout « fonctionne », besoin d'une review ❤️

Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

This changes the behaviour of admin access from a single toggle to fine-tuned permissions.
The permissions hierarchy basically works as follows: Manage > ManageXXX > List.
There are a few exceptions, such as the project hierarchy, in which the Manage permission from admin roles gives access to certain resources inside a project, while ManageProjects only manages the resource itself.
This means that Manage acts as a sort of equivalent to sudo; it's an intermediary design choice, but it needs revising.

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I07287d8d2c8fd287a9fbaefc9019f81a6a6a6964
@cloud-pi-native-sonarqube
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built preview Deploy preview app with Argo-cd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants