remember paper size and orientation on PDF export dialog during session#298
Closed
dbelyaev wants to merge 3 commits into
Closed
remember paper size and orientation on PDF export dialog during session#298dbelyaev wants to merge 3 commits into
dbelyaev wants to merge 3 commits into
Conversation
added 2 commits
March 9, 2016 23:02
ExportPdfDialog instance will be created only once during working session, it will give oss behaviour when last used settings will be shown on next execution of dialog
Collaborator
Author
|
it implements functionality requested in issue #217 |
… feature/remember-paper-size-pdf-export # Conflicts: # app/mainwindow.cpp # app/mainwindow.h
Owner
|
Hi @dbelyaev, Thank you as always! But I guess #217 asks for a more permanent solution. I mean CuteMarkEd should remember the setup across application launches. My idea was to store and retrieve the settings from the Option class. Or since this class is getting rather big already, maybe we should introduce a separate export to pdf option class. The ExportPdfDialog would then use this option class to read or store the settings on open and close. What do you think? Christian |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During working session (from starting application and closing it down) every time call to "Export to PDF" will show dialog window with changes done last time it was executed (orientation and paper size will be the same as in previous execution).