Conversation
Remove check for EAX audio hardware acceleration. It's deprecated.
There was a problem hiding this comment.
Pull request overview
This PR updates the BASS audio library to version 2.5 (based on the copyright year update to 2025). The update modernizes the library by removing deprecated features and adding new functionality.
Changes:
- Updated BASS library binary (bass.lib) with new export symbols
- Updated BASS header file (bass.h) to version 2.5 with API additions, deprecations, and structure changes
- Removed obsolete EAX hardware acceleration check from CSoundSystem
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cleo_plugins/Audio/bass/bass.lib | Binary import library updated with new version's export symbols |
| cleo_plugins/Audio/bass/bass.h | Header file updated to version 2.5 with new features, removed deprecated constants, and modernized structure definitions |
| cleo_plugins/Audio/CSoundSystem.cpp | Removed EAX field check that no longer exists in updated BASS_INFO structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MiranDMC
left a comment
MiranDMC
left a comment
There was a problem hiding this comment.
Not checked if updated BASS library is actually newer than already included one.
It's newer and stable version. v2.4.18.3 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Virustotal results are same with current: |
3 participants
BASSandsimdjsonlibraries.Tested on game, it seems fine so far.