Fix embedding robustness issues and add CI regression guards#55
Merged
Fix embedding robustness issues and add CI regression guards#55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.py,embed.py,aggregate.py,models.py)test/test_regression_bugfixes.pyregression-guardsjob in.github/workflows/pr-test.yamlBug fixes included
tile_encoderbeforeRegionFeatureExtractorwrapping.start_new_session=Truebeforekillpguse.barrier()calls from inside the per-slidetryblock and propagate failures consistently.Path(cfg.output_dir, None)when--output-diris not provided.Validation
python3 -m unittest discover -s test -p 'test_regression_bugfixes.py'python3 -m compileall slide2vec/main.py slide2vec/embed.py slide2vec/aggregate.py slide2vec/models/models.pyNotes
slide2vec/hs2psubmodule code was not edited.