Offer to delete the old clangd dir after installing a new one.#12
Open
sam-mccall wants to merge 2 commits intomasterfrom
Open
Offer to delete the old clangd dir after installing a new one.#12sam-mccall wants to merge 2 commits intomasterfrom
sam-mccall wants to merge 2 commits intomasterfrom
Conversation
We want the user to get a chance to check the new clangd first, so: - stash the old path away before reloading - when we start up, check if a stashed path exists, was autoinstalled, and is not being used - offer to delete, then clear the stash if they answered Part of clangd/vscode-clangd#285
sam-mccall
added a commit
to clangd/vscode-clangd
that referenced
this pull request
Jan 25, 2022
This was referenced Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the user to get a chance to check the new clangd first, so:
and is not being used
Part of clangd/vscode-clangd#285