fix(build): drop hardcoded /root Go paths from Makefile (lr-3458)#11
Conversation
The shipped Makefile pinned GOPATH/GOCACHE/GOMODCACHE defaults to /root, breaking the build for any downstream user without /root write access. Remove the overrides entirely so the Go toolchain falls back to its own per-user defaults (rooted under the caller's $HOME). Env-overridability is preserved since the recipes no longer set these vars at all -- any value already exported by the caller's shell/CI/container passes through untouched. Verified: make build && make test succeed with GOPATH/GOCACHE supplied externally (CI-style) and no /root reference remains in the Makefile.
![clagentic-reviewer[bot]](https://avatars.githubusercontent.com/in/3944489?s=60&v=4){kind=small}
There was a problem hiding this comment.
PEACHES — clean
Reviewed commit 36a7e9a on branch fix/lr-3458-makefile-root-paths.
Summary
Makefile change successfully removes hardcoded /root Go paths (GOPATH, GOMODCACHE, GOCACHE) and delegates to Go toolchain defaults. Environment-override behavior is preserved: any caller exporting these vars will have them respected automatically. Only Makefile changed; .crew/ untouched; no Go source modified.
Checked
- amos.code-craft.1 (minimal change) — Makefile only, 4 lines deleted, 5 lines added (comment + recipe updates), no scope creep
- amos.code-craft.10 (no hardcoded secrets/paths) — All
/rootreferences removed; no new hardcoded values introduced - Review focus: /root path removal — ✓ Lines 1–4 (old GOPATH/GOMODCACHE/GOCACHE) deleted completely
- Review focus: env-overridability preserved — ✓ Comment explicitly documents fallback to Go defaults; recipes no longer set env vars, so inherited exports win
- Review focus: all targets functional — ✓ build, test, vet, fmt, check targets all present and updated
- Review focus: ONLY Makefile changed — ✓ Diff shows no .crew/, Go source, or other files modified
No findings.
![clagentic-security[bot]](https://avatars.githubusercontent.com/in/4134208?s=60&v=4){kind=small}
There was a problem hiding this comment.
BOBBIE — clean
Security audit of PR #11 (lr-3458, Makefile-only change).
Scope confirmed: only Makefile changed (verified via git show --name-only against head SHA below). No .crew/, no Go source, no scripts touched.
Injection / unsafe-exec surface: none introduced. The diff removes the GOENV := GOPATH=... GOMODCACHE=... GOCACHE=... prefix and the hardcoded /root-rooted ?= defaults from all four recipes (build, test, vet, fmt). Remaining recipes are bare go build ./..., go test ./..., go vet ./..., go fmt ./... — no $(shell ...) substitution, no new external command invocations, no unquoted variable expansion, no user-controlled input reaching a recipe line. Env-overridability is preserved because the recipes no longer set these vars at all, so an externally exported GOPATH/GOMODCACHE/GOCACHE simply passes through.
Secrets: none. gitleaks (no-git mode) and semgrep (p/secrets, multilang) both ran clean on the Makefile and repo tree — 0 findings.
findings: none.
scanners_run: gitleaks(clean), semgrep(p/secrets, clean), osv-scanner(skip — no dependency manifest changed)
audit_scope.head_sha: 36a7e9a
clagentic gate-note — authorized
Authorize rationale: PEACHES clean (0 findings, Makefile-only /root path removal), BOBBIE clean (0 findings, stamped head 36a7e9a). Pre-checks + CI verified green at HEAD by crew_merge.py. Authorized by holden (project lead) / andy operator directive 2026-07-04. task lr-3458. |
Remove hardcoded /root Go paths from the shipped Makefile so the build works for downstream users of this FSL-licensed shared product (product-hygiene, workspace rule 11 -- no machine/org-specific paths in platform code).
What changed:
Why: the previous defaults assumed /root write access, which only holds in our own container. Any downstream user without that access, or on a machine with no /root/go, would fail to build. Removing the override is the smallest change that fixes this while keeping our own env overrides working exactly as before.
Scope: Makefile only. No .crew/ changes (gitignored, our-env-only per task note), no Go source changes.
Task: lr-3458
Test status: make build, make test, make vet verified passing with GOPATH/GOCACHE/GOMODCACHE supplied via the caller (simulating a CI/container environment that pins them), confirming the question-mark-equals pass-through semantics hold. No /root reference remains in the tracked Makefile.