Make breadcrumbs persist when you go up the chain.#318
Open
Torgen wants to merge 5 commits intocjb:masterfrom
Open
Make breadcrumbs persist when you go up the chain.#318Torgen wants to merge 5 commits intocjb:masterfrom
Torgen wants to merge 5 commits intocjb:masterfrom
Conversation
Contributor
Author
|
In this version there's a 'chat' button in the breadcrumbs for each level that has chat. It takes up a lot of space, it's weird when they all just say "chat", it takes up even more space if it says "Puzzle chat", "Round chat", etc., and it looks really weird with the icon but no label, both because rollover doesn't do anything when there's no text and because of all the empty space around it. I tried a version where I collapse the padding between the chat and the level it belongs to, but that looks weird when it's active because the padding is missing from only one side. I could try something like put "Puzzle: ${name} (spreadsheet icon) (link icon) (chat icon) Chat" in one <li> and underline the one that's currently in use. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #260