Skip to content

Fix popularity exclude issue while campaign compare #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DH30124 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix popularity exclude issue while campaign compare #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,7 @@ function cnBatchForms(cnFlexFormConfig, cnFlexFormService, cnFlexFormTypes, sfPa

config.default = config.default || 'replace';

if (_.allEqual(config.ogValues)) {
if (_.allEqual(config.ogValues, ['popularity'])) {
// fucking angular infdigs
$timeout(function () {
return cnFlexFormService.parseExpression(field.key, _this8.model).set(_.first(angular.copy(config.ogValues)), { silent: true });
Expand Down
2 changes: 1 addition & 1 deletion dist/all.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/all.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/cn-batch-forms.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ function cnBatchForms(

config.default = config.default || 'replace';

if(_.allEqual(config.ogValues)) {
if(_.allEqual(config.ogValues, ['popularity'])) {
// fucking angular infdigs
$timeout(() =>
cnFlexFormService.parseExpression(field.key, this.model).set(_.first(angular.copy(config.ogValues)), { silent: true })
Expand Down
2 changes: 1 addition & 1 deletion tests/output/test.bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11544,7 +11544,7 @@ function cnBatchForms(cnFlexFormConfig, cnFlexFormService, cnFlexFormTypes, sfPa

config.default = config.default || 'replace';

if (_.allEqual(config.ogValues)) {
if (_.allEqual(config.ogValues, ['popularity'])) {
// fucking angular infdigs
$timeout(function () {
return cnFlexFormService.parseExpression(field.key, _this8.model).set(_.first(angular.copy(config.ogValues)), { silent: true });
Expand Down