maintenance: upgrade to Rust 1.95#8
Conversation
This commit upgrades to Rust 1.95 by upgrading the Rust version in the CI pipeline and fixing newly reported clippy issues.
There was a problem hiding this comment.
Pull request overview
Upgrades CI to Rust 1.95.0 and applies small Rust code adjustments to address newly triggered clippy lints as part of the toolchain bump.
Changes:
- Bump GitHub Actions workflows to use Rust
1.95.0. - Fix clippy warnings by simplifying iterator usage (
into_iter()removal;iter()+ unused key replaced withvalues()). - Update
CHANGELOG.mdto reflect the Rust 1.95 upgrade and clippy fixes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
crates/taco-interval-ta/src/builder/static_interval_order/simple_order_generator.rs |
Removes unnecessary .into_iter() calls when passing vectors into and_many. |
crates/taco-interval-ta/src/builder/static_interval_order.rs |
Replaces `.iter().flat_map( |
CHANGELOG.md |
Notes clippy fixes and Rust 1.95 upgrade. |
.github/workflows/test.yml |
Updates pinned Rust version to 1.95.0 for CI jobs. |
.github/workflows/static.yml |
Updates pinned Rust version to 1.95.0 for docs deploy workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| env: | ||
| CARGO_TERM_COLOR: always | ||
| RUST_VERSION: "1.94.0" | ||
| RUST_VERSION: "1.95.0" |
There was a problem hiding this comment.
RUST_VERSION is bumped, but the doc_check job still runs cargo test / cargo doc without selecting that toolchain, so those steps will execute on whatever the runner's default toolchain is (and may not be 1.95.0). Consider either prefixing these commands with +${RUST_VERSION} or setting rustup default ${RUST_VERSION} (or rustup override set) early in the job to ensure the pinned version is actually used.
| env: | ||
| CARGO_TERM_COLOR: always | ||
| RUST_VERSION: "1.94.0" | ||
| RUST_VERSION: "1.95.0" |
There was a problem hiding this comment.
This workflow pins RUST_VERSION, but later steps (e.g., cargo doc in “Generate Docs”) run without +${RUST_VERSION} and will use the runner's default toolchain unless you set it explicitly. To make the Rust 1.95 upgrade effective/reproducible, either run cargo +${RUST_VERSION} ... for these commands or set rustup default ${RUST_VERSION} after installation.
This commit upgrades to Rust 1.95 by upgrading the Rust version in the CI pipeline and fixing newly reported clippy issues.