add Network-Conditions-Emulator#6
Conversation
There was a problem hiding this comment.
Hi @marty90, this looks like a nice tc wrapper. I do have one pedantic concern which is the usage of the go function to arbitrarily eval input/replaces the go command in potentially sourcing scripts. Do you have any specific reason for using this go function instead of natively calling the commands? Otherwise, would it be possible to modify the code to natively call the commands?
Also, would you be okay with moving this to be a child bullet point of tc as it explicitly wraps tc functionality?
|
Hi Remingtonc! No problem in putting it in a bullet of tc.. it is actually a wrapper that simplify the usage of tc... about the “go” macro: it was used just for debugging. uncommenting one line makes the bash print each command before executing. I agree that it is not super clean. I’m removing it in few days as I finish some tests :) Thank you |
|
@marty90 Wonderful, ping me when it's ready to go and we will merge it in! |
No description provided.