feat: allow disabling pushd with --no-cd#52
Open
pdecat wants to merge 1 commit intocisagov:developfrom
Open
Conversation
pdecat
commented
Dec 13, 2024
| # Global variable arrays | ||
| ARGS=() | ||
| FILES=() | ||
| export NO_CD=0 |
Author
There was a problem hiding this comment.
export is needed to silence shellcheck SC2034.
It works without it, but shellcheck complains:
shellcheck...............................................................Failed
- hook id: shellcheck
- exit code: 1
In lib/util.sh line 23:
NO_CD=1
^---^ SC2034 (warning): NO_CD appears unused. Verify use (or export if used externally).
0d4ffdb to
d45af30
Compare
d45af30 to
7663742
Compare
Author
|
Rebased on develop to resolve conflicts |
7663742 to
28c36aa
Compare
Author
|
Resolved linting issues, not sure how they passed local pre-hooks in the first place 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR allows to alter
packer_validatebehavior to not change working directory when--no-cdis passed as an argument, like it was before #47.💭 Motivation and context
Closes #51
🧪 Testing
Tested locally with and without passing
--no-cdas args, e.g.:✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist