Add a moving average for SPS #1497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a linked list to ChunkyFxController and update setSamplesPerSecond to use this to set the SPS value based on a moving average
leMaik
requested changes
Oct 23, 2022
chunky/src/java/se/llbit/chunky/ui/controller/ChunkyFxController.java
Outdated
Show resolved
Hide resolved
chunky/src/java/se/llbit/chunky/ui/controller/ChunkyFxController.java
Outdated
Show resolved
Hide resolved
This reverts commit 8facfc6.
Adds two linked lists that keep track of SPP for the past 3 minutes (configurable), and then use this to compute a moving average
Author
|
Since that first attempt wasn't actually correct, I've reverted it. I've tried again, and this should now work properly and be ready for merging |
Add a hacky fix for when render passes are significantly longer than SPS_AVERAGE_TIME by calculating the average time for a render pass
Member
|
Sorry, I've been pretty busy lately. The code looks fine, I'll refactor the moving average logic into a new class and merge it. Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #697. I can confirm that the SPS value displayed in the ui is now more stable and consistent. Currently this PR averages over the past 150 frames' SPS values, but this is completely arbitrary and subject to change. Plus, I've not set this new behavior to be configurable, but if there is enough demand, I'll try to add that.
I'm completely new to java coding, so let me know if anything isn't correct or is against style guides etc.
Also, I've marked this as a draft because I'm not used to chunky's codebase, so had no idea where to add statements to clear the list used in computing the averages on scene reset (which I think would be preferable), so am after a bit of guidance in that respect.