Skip to content

ZS snapshot [conflict with ABX_script PR as ABX_script one has been rebased]#14

Open
petropusz wants to merge 11 commits into
masterfrom
ZS_snapshot
Open

ZS snapshot [conflict with ABX_script PR as ABX_script one has been rebased]#14
petropusz wants to merge 11 commits into
masterfrom
ZS_snapshot

Conversation

@petropusz

Copy link
Copy Markdown

No description provided.

Comment thread finetune_nullspace.sh Outdated
echo -e "\t-f audio files format in LibriSpeech dataset (without a dot)"
}

while getopts 'd:t:v:c:o:n:s:p:f' flag; do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getopts is stupid and requires a colon after each parameter that is not a flag. So there should be a colon after f:
while getopts 'd:t:v:c:o:n:s:p:f:' flag; do

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated; changed also in eval_abx.py as you suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants