Updated the schema files to work with new requirements.#76
Open
SilvinWillemsen wants to merge 4 commits intoengd_project_2026from
Open
Updated the schema files to work with new requirements.#76SilvinWillemsen wants to merge 4 commits intoengd_project_2026from
SilvinWillemsen wants to merge 4 commits intoengd_project_2026from
Conversation
mberz
requested changes
Apr 17, 2026
Contributor
mberz
left a comment
mberz
left a comment
There was a problem hiding this comment.
Thanks! I have a couple of small comments.
Could you also add the Python versions for which the backend now works to the test configuration?
Removed all specific versions from the requirements file (so that in the future we won't have conflicts with DeepONet dependencies). Finally, changed some path names for local simulation method finding (in config.py). Used to be in app/simulation-backend, now in ../simulation-backend.
…perly. Should figure out a way to have docker and local setups coexist. Also re-added acousticDE as a requirement as we need for the generate_mesh function (we should decouple it at some point though)
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all specific versions from the requirements file (so that in the future we won't have conflicts with DeepONet dependencies).