Skip to content

Skip redundant poll_max_time check when batch is already full#27

Merged
chmodas merged 1 commit into
trunkfrom
redundant-poll
Apr 7, 2026
Merged

Skip redundant poll_max_time check when batch is already full#27
chmodas merged 1 commit into
trunkfrom
redundant-poll

Conversation

@chmodas

@chmodas chmodas commented Apr 7, 2026

Copy link
Copy Markdown
Owner

When is_full() triggers a flush, poll_max_time() was still called unnecessarily, registering a spurious waker and potentially overwriting the flush reason from "size" to "time" in trace output.

When is_full() triggers a flush, poll_max_time() was still called
unnecessarily, registering a spurious waker and potentially overwriting
the flush reason from "size" to "time" in trace output.
@chmodas chmodas merged commit d42aeb5 into trunk Apr 7, 2026
2 checks passed
@chmodas chmodas deleted the redundant-poll branch April 7, 2026 07:42
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.54%. Comparing base (ec6692b) to head (4ce5748).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
src/worker.rs 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk      #27      +/-   ##
==========================================
- Coverage   98.83%   98.54%   -0.30%     
==========================================
  Files           6        6              
  Lines         344      344              
==========================================
- Hits          340      339       -1     
- Misses          4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants