Serialize folder monitor state#7
Open
sickn33 wants to merge 1 commit into
Open
Conversation
6301cb7 to
07246d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FolderMonitorstart/stop state mutations on its private queueisMonitoringread the same queue-owned stateWhy
FolderMonitorhandled file-system events on a private queue, but publicstart/stopmutatedsource,watchedURL,knownFiles, andgenerationfrom the caller thread. That leaves room for races between delayed filesystem scans and settings changes. The old cancel handler also readself.fileDescriptor, which can point to a newer descriptor if monitoring is restarted before the old source finishes cancelling.Verification
git diff --checkxcodebuild test -project DropKit/DropKit.xcodeproj -scheme DropKit -destination 'platform=macOS' -derivedDataPath /private/tmp/dropkit-foldermonitor-derived CODE_SIGNING_ALLOWED=NOpassed 12 tests, 0 failures