Harden release build script#4
Open
sickn33 wants to merge 2 commits into
Open
Conversation
e3eeb60 to
c534852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -euo pipefailxcodebuildrelease output to a log filexcodebuildexit statusDROPKIT_SIGNING_IDENTITYfor normal release buildsDROPKIT_ALLOW_AD_HOC=1Why
The release script currently pipes
xcodebuildthroughgrep ... || true. That can hide build failures and let the script continue until a later artifact check, making the real failure harder to diagnose. It also produces ad-hoc-signed distribution artifacts by default. This keeps concise build output, preserves the actual build failure status, and makes proper release signing the default path.Verification
bash -n scripts/build-release.shbash scripts/build-release.shexits with the expected usage error when no version is providedbash scripts/build-release.sh 9.9.9exits before build/cleanup whenDROPKIT_SIGNING_IDENTITYis missinggit diff --checkI did not run a full release build because the script intentionally cleans build output, clears extended attributes, signs, and creates distribution artifacts.