Skip to content

Harden release build script#4

Open
sickn33 wants to merge 2 commits into
chenyuxiaojin:mainfrom
sickn33:fix-release-build-failures
Open

Harden release build script#4
sickn33 wants to merge 2 commits into
chenyuxiaojin:mainfrom
sickn33:fix-release-build-failures

Conversation

@sickn33

@sickn33 sickn33 commented Jun 29, 2026

Copy link
Copy Markdown

Summary

  • enable stricter shell handling with set -euo pipefail
  • write the full xcodebuild release output to a log file
  • keep showing filtered build/error/warning lines without masking the real xcodebuild exit status
  • require DROPKIT_SIGNING_IDENTITY for normal release builds
  • keep ad-hoc signing available only as an explicit local-test opt-in via DROPKIT_ALLOW_AD_HOC=1
  • re-sign with the app entitlements and verify the final app signature

Why

The release script currently pipes xcodebuild through grep ... || true. That can hide build failures and let the script continue until a later artifact check, making the real failure harder to diagnose. It also produces ad-hoc-signed distribution artifacts by default. This keeps concise build output, preserves the actual build failure status, and makes proper release signing the default path.

Verification

  • bash -n scripts/build-release.sh
  • bash scripts/build-release.sh exits with the expected usage error when no version is provided
  • bash scripts/build-release.sh 9.9.9 exits before build/cleanup when DROPKIT_SIGNING_IDENTITY is missing
  • git diff --check

I did not run a full release build because the script intentionally cleans build output, clears extended attributes, signs, and creates distribution artifacts.

@sickn33 sickn33 changed the title Preserve release build failures Harden release build script Jun 29, 2026
@sickn33 sickn33 force-pushed the fix-release-build-failures branch from e3eeb60 to c534852 Compare June 29, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants