Decode entities in htmlparser2#440
Merged
Merged
Conversation
fixes #248 This changes how text nodes are stored in the DOM: They are now unescaped by default, which leads to a slight overhead when rendering.
Member
Author
|
Also fixes #194. |
Member
Author
|
@matthewmueller Mind taking a look? (Also at #439.) |
only used to ensure every call contained this setting
Contributor
There was a problem hiding this comment.
Are you intentionally mutating the provided options object here? If not, consider:
_.defaults({}, options || {}, defaultOpts);Also, _.defaults treats null/undefined as an empty object, so the || {} is probably unnecessary.
Contributor
There was a problem hiding this comment.
_.defaults treats null/undefined as an empty object
For arguments other than the first, that is.
Member
Author
There was a problem hiding this comment.
Both methods are actually never called with an options object, so this is only to preserve the previous API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #248
This changes how text nodes are stored in the DOM: They are now unescaped by default, which leads to a slight overhead when rendering.