fix: remove Config::DeleteToTrash and Config::ConfiguredTrashFolder #7787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
added a commit
to chatmail/provider-db
that referenced
this pull request
Jan 28, 2026
It is a GMail-specific option that I'm going to delete in chatmail/core#7787
link2xt
force-pushed
the
link2xt/remove-delete-to-trash
branch
from
dcf9329 to
8554181
Compare
link2xt
added a commit
to chatmail/provider-db
that referenced
this pull request
Jan 28, 2026
It is a GMail-specific option that I'm going to delete in chatmail/core#7787
link2xt
force-pushed
the
link2xt/remove-delete-to-trash
branch
5 times, most recently
from
8465605 to
f6163d5
Compare
link2xt
force-pushed
the
link2xt/remove-delete-to-trash
branch
from
f6163d5 to
48d16a0
Compare
link2xt
force-pushed
the
link2xt/olqquoysmpyl
branch
from
145c306 to
95c43e4
Compare
link2xt
force-pushed
the
link2xt/remove-delete-to-trash
branch
from
48d16a0 to
694e264
Compare
link2xt
force-pushed
the
link2xt/olqquoysmpyl
branch
from
95c43e4 to
d2c5bc7
Compare
link2xt
force-pushed
the
link2xt/remove-delete-to-trash
branch
from
694e264 to
c5cb62e
Compare
Collaborator
Author
|
See also #7648 (comment) for reasons. |
This prevents triggering clippy lint `needless_update`.
link2xt
force-pushed
the
link2xt/remove-delete-to-trash
branch
from
c5cb62e to
b5f75f1
Compare
Hocuri
approved these changes
Jan 30, 2026
Collaborator
Hocuri
left a comment
Hocuri
left a comment
There was a problem hiding this comment.
Nice to get rid of stuff!
FTR, if you have a GMail account, (apart from just switching to a proper provider), this is what you can do:
In the settings in the "forwarding and POP/IMAP" category, change:
When a message is marked as deleted and expunged from the last visible IMAP folder:
Archive the message (default) Move the message to the Trash Immediately delete the message forever (change to this option)
iequidoo
approved these changes
Jan 31, 2026
Collaborator
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
Agree that this should be removed. I can't even understand now why this code was added if it's possible to reconfigure the behavior in the Gmail web UI. Maybe because the user may have another MUA, but wants only Delta Chat messages being immediately deleted. Not important anymore anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_to_trashis an option that was added for Gmail as Gmail archives the messages by defaultwhen they are deleted over IMAP:
#3957
(implemented in #3972).
Closes #6444.