Skip to content

feat: add Ch and Ex helper functions for character-based CSS units#172

Merged
chasefleming merged 1 commit into
chasefleming:mainfrom
Laaaaksh:feat-adding_ch_ex_css_functions
Oct 20, 2025
Merged

feat: add Ch and Ex helper functions for character-based CSS units#172
chasefleming merged 1 commit into
chasefleming:mainfrom
Laaaaksh:feat-adding_ch_ex_css_functions

Conversation

@Laaaaksh

@Laaaaksh Laaaaksh commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Fixes Issue - #170

  • Add Ch(value float64) function for character units (ch)
  • Add Ex(value float64) function for x-height units (ex)
  • Include comprehensive tests for both functions
  • Follow existing patterns for float64 unit functions

- Add Ch(value float64) function for character units (ch)
- Add Ex(value float64) function for x-height units (ex)
- Include comprehensive tests for both functions
- Follow existing patterns for float64 unit functions
@chasefleming chasefleming requested a review from Copilot October 20, 2025 23:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for two CSS character-based units by introducing helper functions Ch() and Ex() for generating character unit (ch) and x-height unit (ex) CSS values respectively.

Key Changes:

  • Added Ch() function to generate CSS character unit values with float64 input
  • Added Ex() function to generate CSS x-height unit values with float64 input
  • Added comprehensive test coverage for both functions following existing test patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
styles/utils.go Implements Ch() and Ex() helper functions for character-based CSS units
styles/utils_test.go Adds test cases for Ch() and Ex() functions covering various input scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@chasefleming chasefleming left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@chasefleming chasefleming merged commit 224da05 into chasefleming:main Oct 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants