Skip to content

fix: keyframe names are ordered#171

Merged
chasefleming merged 1 commit into
chasefleming:mainfrom
whisk:fix/keyframes-order
Oct 18, 2025
Merged

fix: keyframe names are ordered#171
chasefleming merged 1 commit into
chasefleming:mainfrom
whisk:fix/keyframes-order

Conversation

@whisk

@whisk whisk commented Oct 18, 2025

Copy link
Copy Markdown
Contributor

Description

Ocassionally keyframes were out of order. Yesterday I got this error in the PR pipeline:

"[.] @keyframes anim_5c67ab5b65 { to { color: blue; } from { color: red; } } [...]" 
does not contain "@keyframes anim_5c67ab5b65 { from { color: red; } to { color: blue; } }"

Test:       	TestGenerateCSS

I wonder why this didn't happen more often.

Fix

sortedKeys, and I made it accept generic maps.

@chasefleming chasefleming left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@chasefleming chasefleming merged commit 589ac3e into chasefleming:main Oct 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants