added content escaping for comment nodes#159
Merged
Merged
Conversation
chasefleming
requested changes
Jul 15, 2025
chasefleming
left a comment
chasefleming
left a comment
Owner
There was a problem hiding this comment.
Thanks for adding this! Left a couple comments.
| } | ||
|
|
||
| // EscapeCommentContents escapes the contents of a comment node to ensure safe rendering according to https://html.spec.whatwg.org/multipage/syntax.html#comments | ||
| func EscapeCommentContents(s string) string { |
Owner
There was a problem hiding this comment.
Covers all the major disallowed sequences, but stray “--” inside comments isn’t caught yet per the HTML spec.
Owner
|
I think |
Owner
|
@whisk Looks like a conflict now after merging your other PR. |
whisk
force-pushed
the
fix/comments-escaping
branch
from
bfb5b83 to
1a832fc
Compare
chasefleming
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comment()now escapes special character sequences for safe rendering as described in https://html.spec.whatwg.org/multipage/syntax.html#comments