fix(powernap): handle workspace/workspaceFolders and guard router on nil params#611
Open
csacca wants to merge 1 commit into
Open
fix(powernap): handle workspace/workspaceFolders and guard router on nil params#611csacca wants to merge 1 commit into
csacca wants to merge 1 commit into
Conversation
… params nil-safe - Register handler for server-initiated workspace/workspaceFolders to return configured folders (or empty). - Guard Router.Route against nil Params for both requests and notifications to avoid panics. - Add tests covering handler registration and nil Params behavior.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 31.33% 0.62% -30.71%
==========================================
Files 160 14 -146
Lines 14433 4137 -10296
==========================================
- Hits 4523 26 -4497
+ Misses 9628 4108 -5520
+ Partials 282 3 -279 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Tests
Verification
Notes
workspace/workspaceFoldersbut lacks handler; router panics on nil params #610.