Share level pointer so child loggers inherit parent level changes#209
Open
c-tonneslan wants to merge 1 commit into
Open
Share level pointer so child loggers inherit parent level changes#209c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
When With() copies the logger struct, the level field was copied by value, so the child got its own independent level. That meant calling SetLevel on the parent after creating a child had no effect on the child. Change level from int64 to *int64 so parent and child share the same underlying value. All atomic reads/writes already go through atomic.LoadInt64/atomic.StoreInt64, just without the address-of operator now. Also drop the mutex in GetLevel and SetLevel since the atomics are sufficient for thread safety on their own. Fixes charmbracelet#184.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184.
When
With()copies the logger struct, thelevelfield was copied by value, so the child got its own independent level. CallingSetLevelon the parent after creating a child had no effect on the child.The fix is straightforward: change
levelfromint64to*int64. Since parent and child now share the same pointer, aSetLevelcall on either one is immediately visible to both. All the atomic reads/writes already go throughatomic.LoadInt64/atomic.StoreInt64, they just don't need the address-of operator anymore. Also dropped the mutex fromGetLevelandSetLevelsince the atomics are sufficient.Added a regression test in
logger_test.go(TestWithInheritsParentLevel) that verifies the child sees the parent's level changes in both directions.To test: run
go test -run TestWithInheritsParentLevel ./...