fix(web): redirect /sign-on and /sign-in aliases to /login#175
fix(web): redirect /sign-on and /sign-in aliases to /login#175chanced58 wants to merge 1 commit into
Conversation
Users hitting /sign-on (or /signon, /sign-in, /signin) from external links, bookmarks, or marketing material were getting a 404 because the canonical auth route is /login. Add permanent (308) redirects in next.config.js so these aliases resolve to /login while preserving any query string (e.g. ?redirectTo=...). https://claude.ai/code/session_013ethRW9NqTnVekzxjDXbRT
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA Next.js redirect configuration is added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Summary
/loginand no/sign-onroute exists in the app.apps/web/next.config.jsso/sign-on,/signon,/sign-in, and/signinall resolve to/login. Query strings (e.g.?redirectTo=...) flow through automatically, so existing middleware behavior on/loginis preserved./loginand remains correct.Test plan
pnpm --filter web dev, thencurl -sI http://localhost:3000/sign-onreturnsHTTP/1.1 308 Permanent Redirectwithlocation: /login./signon,/sign-in,/signin.http://localhost:3000/loginstill loads the login page unchanged.http://localhost:3000/sign-on?redirectTo=/dashboardredirects to/login?redirectTo=/dashboard(query string preserved).pnpm --filter web lint— exit 0, no new warnings.pnpm --filter web type-check— passes.https://claude.ai/code/session_013ethRW9NqTnVekzxjDXbRT
Generated by Claude Code
Summary by CodeRabbit