Skip to content

fix(web): redirect /sign-on and /sign-in aliases to /login#175

Open
chanced58 wants to merge 1 commit into
mainfrom
claude/fix-sign-on-TkCbn
Open

fix(web): redirect /sign-on and /sign-in aliases to /login#175
chanced58 wants to merge 1 commit into
mainfrom
claude/fix-sign-on-TkCbn

Conversation

@chanced58
Copy link
Copy Markdown
Owner

@chanced58 chanced58 commented Apr 29, 2026

Summary

  • Users clicking a "sign-on" link (from external mail, marketing, or bookmarks) were hitting a 404 because the canonical auth route is /login and no /sign-on route exists in the app.
  • Adds permanent (308) redirects in apps/web/next.config.js so /sign-on, /signon, /sign-in, and /signin all resolve to /login. Query strings (e.g. ?redirectTo=...) flow through automatically, so existing middleware behavior on /login is preserved.
  • No application code, middleware, or UI changed — the existing "Sign in" button on the homepage already points at /login and remains correct.

Test plan

  • pnpm --filter web dev, then curl -sI http://localhost:3000/sign-on returns HTTP/1.1 308 Permanent Redirect with location: /login.
  • Same for /signon, /sign-in, /signin.
  • http://localhost:3000/login still loads the login page unchanged.
  • http://localhost:3000/sign-on?redirectTo=/dashboard redirects to /login?redirectTo=/dashboard (query string preserved).
  • pnpm --filter web lint — exit 0, no new warnings.
  • pnpm --filter web type-check — passes.

https://claude.ai/code/session_013ethRW9NqTnVekzxjDXbRT


Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Improved sign-in URL routing by consolidating multiple sign-in URL patterns to consistently redirect to the main login page.

Users hitting /sign-on (or /signon, /sign-in, /signin) from external
links, bookmarks, or marketing material were getting a 404 because the
canonical auth route is /login. Add permanent (308) redirects in
next.config.js so these aliases resolve to /login while preserving any
query string (e.g. ?redirectTo=...).

https://claude.ai/code/session_013ethRW9NqTnVekzxjDXbRT
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 53228dc1-7f79-4f25-8d75-0c54b66af2b7

📥 Commits

Reviewing files that changed from the base of the PR and between ddadc82 and 544ccc9.

📒 Files selected for processing (1)
  • apps/web/next.config.js

📝 Walkthrough

Walkthrough

A Next.js redirect configuration is added to nextConfig that permanently maps multiple sign-in URL variants (/sign-on, /signon, /sign-in, /signin) to the canonical /login route using an async redirects() function.

Changes

Cohort / File(s) Summary
Next.js Configuration
apps/web/next.config.js
Added async redirects() method to nextConfig that establishes permanent HTTP redirects from four sign-in URL variants to the /login route.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Four pathways now converge as one,
Sign-on, signon, sign-in—all done!
To /login they gently flow,
A redirect waltz, you know! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding redirects for /sign-on and /sign-in aliases to the canonical /login route, which directly matches the changeset's core purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-sign-on-TkCbn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants