fix(mates): restore mention indicator across view switches and DOM rebuilds#308
Open
leiyangyou wants to merge 1 commit intochadbyte:mainfrom
Open
fix(mates): restore mention indicator across view switches and DOM rebuilds#308leiyangyou wants to merge 1 commit intochadbyte:mainfrom
leiyangyou wants to merge 1 commit intochadbyte:mainfrom
Conversation
…DOM rebuilds Track active mention mateId server-side and re-send mention_processing on session switch. Cache mention-active state client-side so renderUserStrip DOM rebuilds preserve the processing dot and blink animation.
leiyangyou
force-pushed
the
fix/mention-indicator
branch
from
dff6ca8 to
cab1f84
Compare
Owner
|
Heads up — this has merge conflicts after the recent refactoring (app.js / sidebar.js decomposition). Could you rebase against main when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan