Remove async_timeout and update python versions#94
Open
xavierforestier wants to merge 6 commits into
Open
Conversation
…timeout-deps Fix/remove obsolete async timeout deps
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces async_timeout with asyncio.timeout in the RMV API client, updates the GitHub Actions test matrix to newer Python versions, and applies minor Python style cleanups in tests. Sequence diagram for RMV API query using asyncio.timeoutsequenceDiagram
participant RMVClient
participant asyncio
participant HttpxAsyncClient as httpx.AsyncClient
participant RMV_API
RMVClient->>asyncio: timeout(self._timeout)
activate asyncio
asyncio->>HttpxAsyncClient: __aenter__()
activate HttpxAsyncClient
HttpxAsyncClient->>RMV_API: get(url)
RMV_API-->>HttpxAsyncClient: response
HttpxAsyncClient-->>RMVClient: response
deactivate HttpxAsyncClient
asyncio-->>RMVClient: __aexit__()
deactivate asyncio
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since the workflow now only tests 3.11–3.14 and uses asyncio.timeout, make sure your packaging metadata (e.g., pyproject.toml/setup.cfg classifiers and requires-python) is updated to reflect the new minimum Python version.
- Now that async_timeout has been replaced with asyncio.timeout, remove any remaining async-timeout dependency declarations from your dependency files so they stay in sync with the code.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the workflow now only tests 3.11–3.14 and uses asyncio.timeout, make sure your packaging metadata (e.g., pyproject.toml/setup.cfg classifiers and requires-python) is updated to reflect the new minimum Python version.
- Now that async_timeout has been replaced with asyncio.timeout, remove any remaining async-timeout dependency declarations from your dependency files so they stay in sync with the code.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…timeout-deps Update python, remove async_timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update async timeout handling and modernize supported Python versions.
Enhancements:
CI: