Use astropy for FITS I/O and WCS transformations + photutils for aperture photometry#1
Closed
cgobat wants to merge 11 commits into
Closed
Use astropy for FITS I/O and WCS transformations + photutils for aperture photometry#1cgobat wants to merge 11 commits into
cgobat wants to merge 11 commits into
Conversation
Doesn't seem like this is even used anywhere currently, but this is more robust regardless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Many smart people have put lots of time and effort into making packages like astropy and photutils work very well. As far as I can see, there's no reason not to use them, especially when they are already dependencies elsewhere (i.e., using them doesn't even add any additional installation requirements).
Using widely-used/pre-existing/well-documented packages to do these kinds of things makes the codebase much more robust, readable, and maintainable compared to bespoke reimplementations/reinventions of the wheel.
Type
Does this affect:
If yes, link discussion issue:
→ #
Testing
Notes
cc @edjuh