Skip to content

Comments

Add textToSpeech Command#18

Open
XtremeOwnageDotCom wants to merge 2 commits intocgarwood:masterfrom
XtremeOwnageDotCom:patch-1
Open

Add textToSpeech Command#18
XtremeOwnageDotCom wants to merge 2 commits intocgarwood:masterfrom
XtremeOwnageDotCom:patch-1

Conversation

@XtremeOwnageDotCom
Copy link

Copy link
Owner

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to at minimum pass the text parameter along, but support for locale and engine would be good to include as well

Add parameters
@XtremeOwnageDotCom
Copy link
Author

Added parameters. (Might double-check to ensure the logic is correct.)

I have not spent too much time looking at how this library is configured- I am mostly just trying to mimic some of the other configured endpoints-

The origin of this request came from my TTS functionality not working directly from home assistant. After spending a few hours, I ended up reverting to just calling the rest-api directly.

If/when this PR was merged, the next part would be to update your integration on the home-assistant side to actually expose this as a service. But, since, the home-assistant integration references this particular library- this PR was a prerequisite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants