Skip to content

ENT-13573: Changed ChangePasswordHashUsingChpass logging info (3.21.x) #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleksandrychev merged 2 commits into from
Dec 8, 2025
Merged

ENT-13573: Changed ChangePasswordHashUsingChpass logging info (3.21.x) #5986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff144f
Changed ChangePasswordHashUsingChpass logging info
aleksandrychev Dec 5, 2025
deb3b2a
Do not log executed command by ExecuteUserCommand
aleksandrychev Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cf-agent/verify_users_pam.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,19 +650,19 @@ static bool ExecuteUserCommand(const char *puser, const char *cmd, size_t sizeof
return false;
}

Log(LOG_LEVEL_VERBOSE, "%s user '%s'. (command: '%s')", cap_action_msg, puser, cmd);
Log(LOG_LEVEL_VERBOSE, "ExecuteUserCommand: %s user '%s'.", cap_action_msg, puser);

FILE *fptr = cf_popen(cmd, "w", true);
if (!fptr)
{
Log(LOG_LEVEL_ERR, "Command returned error while %s user '%s'. (Command line: '%s')", action_msg, puser, cmd);
Log(LOG_LEVEL_ERR, "ExecuteUserCommand: returned error while %s user '%s'.", action_msg, puser);
return false;
}

int status = cf_pclose(fptr);
if (status)
{
Log(LOG_LEVEL_ERR, "'%s' returned non-zero status: %i\n", cmd, status);
Log(LOG_LEVEL_ERR, "ExecuteUserCommand: returned non-zero status: %i\n", status);
return false;
}

Expand All @@ -680,7 +680,7 @@ static bool ChangePasswordHashUsingChpass(const char *puser, const char *passwor
StringAppend(cmd, "\' ", sizeof(cmd));
StringAppend(cmd, puser, sizeof(cmd));

Log(LOG_LEVEL_VERBOSE, "Changing password hash for user '%s'. (command: '%s')", puser, cmd);
Log(LOG_LEVEL_VERBOSE, "Changing password hash for user '%s' using chpass.", puser);

return ExecuteUserCommand(puser, cmd, sizeof(cmd), "changing", "Changing");
}
Expand Down
Loading