ent 13535/master #5981
Closed
ent 13535/master #5981
+148
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
craigcomstock
commented
Dec 4, 2025
craigcomstock
commented
- Constified command argument in ExecPackageCommand()
- Packages promiser is now escaped when using shell commands
- Fixed package related acceptance test for Windows platform related to quoting arguments
Contributor
Author
|
|
Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
I also refactored the code to use a dynamic buffer when assembling the commands. Estimating the buffer size needed is error prone and can quickly lead to buffer overflows. Ticket: ENT-13535 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
craigcomstock
force-pushed
the
ent-13535/master
branch
from
af1f107 to
916b49d
Compare
Contributor
Author
|
failures are acceptable, DTs won't run with only windows platform. |
… quoting arguments Ticket: ENT-13535 Changelog: none
craigcomstock
force-pushed
the
ent-13535/master
branch
from
916b49d to
6f97d0a
Compare
Contributor
Author
|
this fix is taken at #5967 so this PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.