Skip to content

Revert cef 130#101

Closed
aiden-jeffrey wants to merge 2 commits intocentricular:masterfrom
aiden-jeffrey:aiden/revert-cef-130
Closed

Revert cef 130#101
aiden-jeffrey wants to merge 2 commits intocentricular:masterfrom
aiden-jeffrey:aiden/revert-cef-130

Conversation

@aiden-jeffrey
Copy link
Copy Markdown
Contributor

Updating to cef 130 broke the GST_CEF_LOG_SEVERITY functionality. I will investigate further, but for now we should probably roll back to 122.

@MathieuDuponchelle
Copy link
Copy Markdown
Collaborator

This seems contradictory with #98 :) Does the log severity issue look hard to fix ?

@aiden-jeffrey
Copy link
Copy Markdown
Contributor Author

aiden-jeffrey commented Dec 2, 2025

This seems contradictory with #98 :) Does the log severity issue look hard to fix ?

No. Apparently now you need to specify enable-logging=stderr in the CHROME_EXTRA_FLAGS (see here). I'll raise a PR to add this note, unless you want to default it to on always?

@MathieuDuponchelle
Copy link
Copy Markdown
Collaborator

@aiden-jeffrey I think adding a note is OK :) maybe push a separate commit on #98 and I'll merge it?

@aiden-jeffrey
Copy link
Copy Markdown
Contributor Author

maybe push a separate commit on #98 and I'll merge it?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants